Skip to main content

XrmToolBox: AutoNumberUpdater - new StateCode filter

CRM 4.0: Custom Report -> Incorrect syntax near ...

The customer had an issue with a custom CRM 4.0 report.
It seems this error occured now because the SQL Server run with 2008 instead of 2005 or the report indeed had a bug. (Thanks to SQL Profiler, I found it.)

The customer had this error coming up:
Query execution failed for dataset '....'.
Incorrect syntax near '20140913'

After analysing the report XML I figured out the problem:

DECLARE @SQL AS NVARCHAR(MAX)
SET @SQL = '
SELECT
CRMAF_FilteredAccount.accountid,
CRMAF_FilteredContact.firstname,
CRMAF_FilteredContact.jobtitle,
CRMAF_FilteredContact.lastname,
CRMAF_FilteredContact.telephone1
FROM (' + @CRM_FilteredAccount + ') AS CRMAF_FilteredAccount INNER JOIN FilteredContact AS CRMAF_FilteredContact
ON CRMAF_FilteredAccount.accountid = CRMAF_FilteredContact.parentcustomerid
ORDER BY CRMAF_FilteredContact.lastname'
EXEC(@SQL)

The red must be replaced with:

DECLARE @SQL AS NVARCHAR(MAX)
SET @SQL = '
SELECT
CRMAF_FilteredAccount.accountid,
CRMAF_FilteredContact.firstname,
CRMAF_FilteredContact.jobtitle,
CRMAF_FilteredContact.lastname,
CRMAF_FilteredContact.telephone1
FROM (' + @CRM_FilteredAccount + ') AS CRMAF_FilteredAccount INNER JOIN (' + @CRM_FilteredContact + ') AS CRMAF_FilteredContact
ON CRMAF_FilteredAccount.accountid = CRMAF_FilteredContact.parentcustomerid
ORDER BY CRMAF_FilteredContact.lastname'
EXEC(@SQL)

And I had to insert the appropriate and equivalent new report and query parameter for it.

SQL Profiler Output:
exec sp_executesql N'declare @binUserGuid varbinary(128)
           declare @userGuid uniqueidentifier
           select @userGuid = N''{2691f84a-3327-e111-926d-001e0bd1e5c0}''
           set @binUserGuid = cast(@userGuid as varbinary(128))
           set context_info @binUserGuid
           --DECLARE @CRM_FilteredAccount AS NVARCHAR(MAX)
--SET @CRM_FilteredAccount = ''select * from filteredaccount''
DECLARE @SQL AS NVARCHAR(MAX)
SET @SQL = ''
SELECT
CRMAF_FilteredAccount.accountid,
CRMAF_FilteredContact.firstname,
CRMAF_FilteredContact.jobtitle,
CRMAF_FilteredContact.lastname,
CRMAF_FilteredContact.telephone1
FROM ('' + @CRM_FilteredAccount + '') AS CRMAF_FilteredAccount INNER JOIN (select contact0.* from FilteredContact as contact0 where ( contact0.modifiedonutc >= ''20140913 22:00:00'' and contact0.modifiedonutc <= ''20141014 12:05:42'' )) as CRMAF_FilteredContact
ON CRMAF_FilteredAccount.accountid = CRMAF_FilteredContact.parentcustomerid
ORDER BY CRMAF_FilteredContact.lastname''
EXEC(@SQL)',N'@CRM_FilteredAccount nvarchar(156)',@CRM_FilteredAccount=N'select account0.* from FilteredAccount as account0 where ( account0.modifiedonutc >= ''20140913 22:00:00'' and account0.modifiedonutc <= ''20141014 12:05:42'' )'


The important difference is how the parameters will be replaced in the final query (red).

Comments

Popular posts from this blog

Yet Another Address Autocomplete PCF Control–powered by Bing

In this blog post I will not go into detail in how to install all the pre-requisites that are required to build and run PCF controls. My goal was to build a new PCF control and get into coding of PCF controls as fast as possible. Here are a few links to articles that will help you installing the pre-requisites (Microsoft PowerApps CLI)  https://docs.microsoft.com/en-us/powerapps/developer/component-framework/get-powerapps-cli Other good references to get into this topic: https://toddbaginski.com/blog/how-to-create-a-powerapps-pcf-control/ https://docs.microsoft.com/en-us/powerapps/developer/component-framework/create-custom-controls-using-pcf I looked through the Guido Preite’s https://pcf.gallery/ which will help you find appropriate use cases / examples for your own needs. It did not take very long to find a simple example to start with: Andrew Butenko's https://pcf.gallery/address-autocomplete/ A few moments later I had the idea to create yet another address autocomplete...

Regarding SPFieldMultiLineText (Add HTML/URL content to a field) programmatically

I recently tried so set some HTML content in a SharePoint list column of type SPFieldMultiLineText. My first approach was this piece of code: SPFieldMultiLineText field = item.Fields.GetFieldByInternalName( "Associated Documents" ) as SPFieldMultiLineText; StringBuilder docList = new StringBuilder(); docList.Append( " " ); foreach (DataRow docRow in addDocs) { DataRow[] parent = dr.Table.DataSet.Tables[0].Select( "DOK_ID=" + docRow[ "DOK_MGD_ID" ].ToString()); if (parent != null && parent.Length > 0) { docList.AppendFormat( " {1} " , parent[0][ "FilePath" ].ToString(), parent[0][ "Title" ].ToString()); } } if (docList.Length > 0) { // remove trailing tag docList.Remove(docList.Length-5, 5); } docList.Append( " " ); string newValue = docList.ToString(); item[field.Title] = newValue; What this code does is to get all associated documents to the main document and to add these docu...

XrmToolBox: AutoNumberUpdater - new StateCode filter

Mayank Pujara's AutoNumberUpdater plugin for the XrmToolBox is a great tool to add missing auto number values to an auto number field for an entity/table. In his blog you can find more details about the original version of his plugin: https://mayankp.wordpress.com/2021/12/09/xrmtoolbox-autonumberupdater-new-tool/ For my purposes I had to update accounts with missing account numbers, but in my use case this should only be done for those accounts that have the status value "Active".   As this plugin did not have this feature I quickly implemented it and Mayank merged my changes to his plugin source code. You can download the new version 1.2024.0.1 in the Tool Library of the XrmToolBox.